From: Frédéric Buclin <LpSolit@gmail.com>
Date: Wed, 2 Jan 2013 15:01:40 +0000 (+0100)
Subject: Bug 824640: The product name generated by collectstats.pl is broken
X-Git-Tag: bugzilla-4.5.1~244
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=31610212aa0731715c913f724001fcd6ab1e1df8;p=thirdparty%2Fbugzilla.git

Bug 824640: The product name generated by collectstats.pl is broken
r=wurblzap a=LpSolit
---

diff --git a/collectstats.pl b/collectstats.pl
index e1a4603f39..bf0c686963 100755
--- a/collectstats.pl
+++ b/collectstats.pl
@@ -204,13 +204,14 @@ sub collect_stats {
 
     if (!$exists || scalar(@data)) {
         my $fields = join('|', ('DATE', @statuses, @resolutions));
+        my $product_name = $product->name;
         print DATA <<FIN;
 # Bugzilla Daily Bug Stats
 #
 # Do not edit me! This file is generated.
 #
 # fields: $fields
-# Product: $product->name
+# Product: $product_name
 # Created: $when
 FIN
     }
@@ -308,13 +309,14 @@ sub regenerate_stats {
 
     if (open DATA, ">$file") {
         my $fields = join('|', ('DATE', @statuses, @resolutions));
+        my $product_name = $product->name;
         print DATA <<FIN;
 # Bugzilla Daily Bug Stats
 #
 # Do not edit me! This file is generated.
 #
 # fields: $fields
-# Product: $product->name
+# Product: $product_name
 # Created: $when
 FIN
         # For each day, generate a line of statistics.
@@ -323,7 +325,7 @@ FIN
         for (my $day = $start + 1; $day <= $end; $day++) {
             # Some output feedback
             my $percent_done = ($day - $start - 1) * 100 / $total_days;
-            printf "\rRegenerating %s \[\%.1f\%\%]", $product->name,
+            printf "\rRegenerating %s \[\%.1f\%\%]", $product_name,
                                                      $percent_done;
 
             # Get a list of bugs that were created the previous day, and
@@ -372,7 +374,7 @@ FIN
 
         # Finish up output feedback for this product.
         my $tend = time;
-        say "\rRegenerating " . $product->name . ' [100.0%] - ' .
+        say "\rRegenerating " . $product_name . ' [100.0%] - ' .
             delta_time($tstart, $tend);
 
         close DATA;