From: Joel Rosdahl <joel@rosdahl.net>
Date: Sat, 2 Aug 2025 16:40:10 +0000 (+0200)
Subject: chore: Remove redundant logging of error
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=316a0c026a579b4710f244dbc1be1c6dfdf22d2e;p=thirdparty%2Fccache.git

chore: Remove redundant logging of error
---

diff --git a/src/ccache/storage/remote/filestorage.cpp b/src/ccache/storage/remote/filestorage.cpp
index 580871cd..26f6af4a 100644
--- a/src/ccache/storage/remote/filestorage.cpp
+++ b/src/ccache/storage/remote/filestorage.cpp
@@ -176,13 +176,12 @@ FileStorageBackend::put(const Hash::Digest& key,
 tl::expected<bool, RemoteStorage::Backend::Failure>
 FileStorageBackend::remove(const Hash::Digest& key)
 {
-  auto entry_path = get_entry_path(key);
-  auto result = util::remove_nfs_safe(entry_path);
-  if (!result) {
-    LOG("Failed to remove {}: {}", entry_path, result.error().message());
+  auto result = util::remove_nfs_safe(get_entry_path(key));
+  if (result) {
+    return *result;
+  } else {
     return tl::unexpected(RemoteStorage::Backend::Failure::error);
   }
-  return *result;
 }
 
 std::string