From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Tue, 19 Jul 2016 13:57:16 +0000 (+0200)
Subject: sources: optimize SRC_ReportSource() a bit
X-Git-Tag: 3.0-pre1~157
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=316d50d6f1a258cdbdcf9a733d86e4cdcb174834;p=thirdparty%2Fchrony.git

sources: optimize SRC_ReportSource() a bit

Remove unnecessary memset() call and use the default case of the switch
to report the unreachable state.
---

diff --git a/sources.c b/sources.c
index 79f72cfe..e5627edc 100644
--- a/sources.c
+++ b/sources.c
@@ -1294,7 +1294,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
   } else {
     src = sources[index];
 
-    memset(&report->ip_addr, 0, sizeof (report->ip_addr));
     if (src->ip_addr)
       report->ip_addr = *src->ip_addr;
     else {
@@ -1304,14 +1303,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
     }
 
     switch (src->status) {
-      case SRC_UNSELECTABLE:
-      case SRC_BAD_STATS:
-      case SRC_BAD_DISTANCE:
-      case SRC_STALE:
-      case SRC_ORPHAN:
-      case SRC_WAITS_STATS:
-        report->state = RPT_UNREACH;
-        break;
       case SRC_FALSETICKER:
         report->state = RPT_FALSETICKER;
         break;
@@ -1331,9 +1322,8 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
       case SRC_SELECTED:
         report->state = RPT_SYNC;
         break;
-      case SRC_OK:
       default:
-        assert(0);
+        report->state = RPT_UNREACH;
         break;
     }