From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 18 Jan 2017 09:56:14 +0000 (+0100)
Subject: virProcessRunInMountNamespace: Report errors from child
X-Git-Tag: CVE-2017-2635~188
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3172d26730b67ba23f9d03e65e8f32b2249f7e12;p=thirdparty%2Flibvirt.git

virProcessRunInMountNamespace: Report errors from child

The comment to the function states that the errors from the child
process are reported. Well, the error buffer is filled with
possible error messages. But then it is thrown away. Among with
important error message from the child process.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index f5c7ebb96f..16eb412127 100644
--- a/src/util/virprocess.c
+++ b/src/util/virprocess.c
@@ -1137,8 +1137,14 @@ virProcessRunInMountNamespace(pid_t pid,
         VIR_FORCE_CLOSE(errfd[1]);
         ignore_value(virFileReadHeaderFD(errfd[0], 1024, &buf));
         ret = virProcessWait(child, &status, false);
-        if (!ret)
+        if (!ret) {
             ret = status == EXIT_CANCELED ? -1 : status;
+            if (ret) {
+                virReportError(VIR_ERR_INTERNAL_ERROR,
+                               _("child reported: %s"),
+                               NULLSTR(buf));
+            }
+        }
         VIR_FREE(buf);
     }