From: Greg Hudson <ghudson@mit.edu>
Date: Wed, 27 Aug 2014 20:15:46 +0000 (-0400)
Subject: Fix minor memory leak in klist (again)
X-Git-Tag: krb5-1.14-alpha1~231
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=319d98bf13e8486f9f378ee47147c9c4bdb15c37;p=thirdparty%2Fkrb5.git

Fix minor memory leak in klist (again)

Commit 6e51f9cc3152c8e419fe7f459bcf521d60358434 attempted to fix two
minor memory leaks in klist, but one of the fixes was dead code.  In
do_ccache, free princ before we look at the code which terminated the
loop, not after we have returned on either branch.
---

diff --git a/src/clients/klist/klist.c b/src/clients/klist/klist.c
index 51eaa07930..9058e8f173 100644
--- a/src/clients/klist/klist.c
+++ b/src/clients/klist/klist.c
@@ -533,6 +533,7 @@ do_ccache(krb5_ccache cache)
         }
         krb5_free_cred_contents(kcontext, &creds);
     }
+    krb5_free_principal(kcontext, princ);
     if (code == KRB5_CC_END) {
         if ((code = krb5_cc_end_seq_get(kcontext, cache, &cur))) {
             if (!status_only)
@@ -555,7 +556,6 @@ do_ccache(krb5_ccache cache)
             com_err(progname, code, _("while retrieving a ticket"));
         return 1;
     }
-    krb5_free_principal(kcontext, princ);
 }
 
 char *