From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Sun, 12 May 2024 09:13:58 +0000 (+0200)
Subject: test: Add cmdline field to configure extra kernel command line args
X-Git-Tag: v256-rc2~18^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=31c797e03d2f24b9b84f1c95cc43aa8c5f35e04a;p=thirdparty%2Fsystemd.git

test: Add cmdline field to configure extra kernel command line args

Configuring extra cmdline arguments as a list is much nicer than
having to pass the --kernel-command-line-extra argument manually.
---

diff --git a/test/TEST-02-UNITTESTS/meson.build b/test/TEST-02-UNITTESTS/meson.build
index 8da55558428..b0003391b5c 100644
--- a/test/TEST-02-UNITTESTS/meson.build
+++ b/test/TEST-02-UNITTESTS/meson.build
@@ -3,15 +3,14 @@
 integration_tests += [
         integration_test_template + {
                 'name' : fs.name(meson.current_source_dir()),
-                'mkosi-args' : integration_test_template['mkosi-args'] + [
-                        '''--kernel-command-line-extra=
-
-frobnicate!
+                'cmdline' : integration_test_template['cmdline'] + [
+                        '''
 
 systemd.setenv=TEST_CMDLINE_NEWLINE=foo
+                        ''',
+                        '''
 systemd.setenv=TEST_CMDLINE_NEWLINE=bar
-
-''',
+                        ''',
                 ],
         },
 ]
diff --git a/test/TEST-06-SELINUX/meson.build b/test/TEST-06-SELINUX/meson.build
index ec4b502b942..dd1dfb0bafe 100644
--- a/test/TEST-06-SELINUX/meson.build
+++ b/test/TEST-06-SELINUX/meson.build
@@ -3,9 +3,7 @@
 integration_tests += [
         integration_test_template + {
                 'name' : fs.name(meson.current_source_dir()),
-                'mkosi-args' : integration_test_template['mkosi-args'] + [
-                        '--kernel-command-line-extra=selinux=1 lsm=selinux'
-                ],
+                'cmdline' : integration_test_template['cmdline'] + ['selinux=1', 'lsm=selinux'],
                 # FIXME; Figure out why reboot sometimes hangs with 'linux' firmware.
                 'firmware' : 'uefi',
         },
diff --git a/test/meson.build b/test/meson.build
index fab802a66d7..61aa01089a9 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -287,6 +287,7 @@ integration_test_template = {
                 'memory-accounting' : 'no',
                 'command' : testdata_dir / 'units/%N.sh',
         },
+        'cmdline' : [],
 }
 testdata_subdirs = [
         'auxv',
@@ -399,7 +400,15 @@ foreach integration_test : integration_tests
                 integration_test_args += ['--slow']
         endif
 
-        integration_test_args += ['--'] + integration_test['mkosi-args']
+        integration_test_args += ['--']
+
+        if integration_test['cmdline'].length() > 0
+                integration_test_args += [
+                        '--kernel-command-line-extra=@0@'.format(' '.join(integration_test['cmdline']))
+                ]
+        endif
+
+        integration_test_args += integration_test['mkosi-args']
 
         integration_test_env = {}