From: Philippe Antoine <pantoine@oisf.net>
Date: Mon, 28 Apr 2025 08:44:09 +0000 (+0200)
Subject: sdp: use rust join
X-Git-Tag: suricata-8.0.0-rc1~408
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=31e30d4aa17e48ede2156651bf586e2e6b99ceb7;p=thirdparty%2Fsuricata.git

sdp: use rust join

It is much faster as it does not do an allocation for each element
---

diff --git a/rust/src/sdp/parser.rs b/rust/src/sdp/parser.rs
index 3ab9d932ca..105bc51f6c 100644
--- a/rust/src/sdp/parser.rs
+++ b/rust/src/sdp/parser.rs
@@ -464,9 +464,9 @@ fn parse_media_description(i: &[u8]) -> IResult<&[u8], MediaDescription> {
         format!("{}", port)
     };
     let mut media_str = format!("{} {} {}", &media, &port, &proto);
-    let fmt: Vec<String> = fmt.into_iter().map(String::from).collect();
-    for f in &fmt {
-        media_str = format!("{} {}", media_str, f);
+    if !fmt.is_empty() {
+        let fmt: Vec<String> = fmt.into_iter().map(String::from).collect();
+        media_str = format!("{} {}", media_str, fmt.join(" "));
     }
     Ok((
         i,