From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 28 Feb 2022 11:53:39 +0000 (+0100)
Subject: lxc_fuse: Prefer O_ACCMODE instead of & 3
X-Git-Tag: v8.2.0-rc1~183
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=320efa9572dbd2f6b5c904efad11798020da40c4;p=thirdparty%2Flibvirt.git

lxc_fuse: Prefer O_ACCMODE instead of & 3

In lxcProcOpen() we want to check whether the /proc/memfile is
being opened only for read. For that we check the fi->flags which
correspond to flags open() call. Instead of explicitly masking
the last two bits use O_ACCMODE constant, which is deemed to be
more portable.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c
index b6b653e8cd..683d01525f 100644
--- a/src/lxc/lxc_fuse.c
+++ b/src/lxc/lxc_fuse.c
@@ -114,7 +114,7 @@ lxcProcOpen(const char *path,
     if (STRNEQ(path, fuse_meminfo_path))
         return -ENOENT;
 
-    if ((fi->flags & 3) != O_RDONLY)
+    if ((fi->flags & O_ACCMODE) != O_RDONLY)
         return -EACCES;
 
     return 0;