From: Jeremy Allison <jra@samba.org>
Date: Thu, 8 Mar 2007 03:00:42 +0000 (+0000)
Subject: r21759: Fix the same bug in a more elegant way, strrchr_m
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~978
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=321a136dbce1a0532f123ea79ecb91f987b9a286;p=thirdparty%2Fsamba.git

r21759: Fix the same bug in a more elegant way, strrchr_m
is an expensive call....
Jeremy.
---

diff --git a/source/smbd/msdfs.c b/source/smbd/msdfs.c
index c34512493ff..861588e6b73 100644
--- a/source/smbd/msdfs.c
+++ b/source/smbd/msdfs.c
@@ -331,6 +331,7 @@ static BOOL resolve_dfs_path(TALLOC_CTX *ctx,
 	SMB_STRUCT_STAT sbuf;
 	NTSTATUS status;
 	pstring reqpath;
+	pstring local_dfspath;
 
 	if (!dp || !conn) {
 		DEBUG(1,("resolve_dfs_path: NULL dfs_path* or NULL connection_struct*!\n"));
@@ -385,6 +386,12 @@ static BOOL resolve_dfs_path(TALLOC_CTX *ctx,
 		return True;
 	}
 
+	/* Prepare to test only for '/' components in the given path,
+	 * so replace all '\\' characters with '/'. */
+
+	pstrcpy(local_dfspath, dfspath);
+	string_replace(local_dfspath, '\\', '/');
+
 	/* redirect if any component in the path is a link */
 	pstrcpy(reqpath, localpath);
 	p = strrchr_m(reqpath, '/');
@@ -402,14 +409,12 @@ static BOOL resolve_dfs_path(TALLOC_CTX *ctx,
 			
 			if (consumedcntp) {
 				pstring buf;
-				pstrcpy(buf, dfspath);
-				trim_char(buf, '\0', '\\');
+				pstrcpy(buf, local_dfspath);
+				trim_char(buf, '\0', '/');
 				for (; consumed_level; consumed_level--) {
-					char *q, *q1, *q2;
-					/* Either '\\' or '/' may be a separator. */
-					q1 = strrchr_m(buf, '\\');
-					q2 = strrchr_m(buf, '/');
-					q = MAX(q1,q2);
+					char *q;
+					/* We made sure only '/' may be a separator above. */
+					q = strrchr_m(buf, '/');
 					if (q) {
 						*q = 0;
 					}