From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 29 Aug 2024 10:32:07 +0000 (+0300)
Subject: pop3: Logout format specifier 'u' is always empty
X-Git-Tag: 2.4.0~1477
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=322a1655352ba6ac2faae5db78ad045d0f31c92f;p=thirdparty%2Fdovecot%2Fcore.git

pop3: Logout format specifier 'u' is always empty

Due to mistake in var_get_key() invocation, if 'u' key is used
the value is never populated. Call var_get_get_key() with correct
short char.

Broken in acfda38b75d0f0e899ef692fef01593bd56ed85e
---

diff --git a/src/pop3/pop3-client.c b/src/pop3/pop3-client.c
index 12f1e9d450..c1150c77c5 100644
--- a/src/pop3/pop3-client.c
+++ b/src/pop3/pop3-client.c
@@ -529,7 +529,7 @@ static const char *client_stats(struct client *client)
 {
 	const char *uidl_change = "";
 	if (var_has_key(client->set->pop3_logout_format,
-			'o', "uidl_change"))
+			'u', "uidl_change"))
 		uidl_change = client_build_uidl_change_string(client);
 
 	const struct var_expand_table logout_tab[] = {