From: Anton Altaparmakov Date: Tue, 20 Jun 2006 07:29:41 +0000 (-0700) Subject: [PATCH] NTFS: Critical bug fix (affects MIPS and possibly others) X-Git-Tag: v2.6.17.2~13 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=323e290abcbdf84afde0fbbd775f3ba4b784655a;p=thirdparty%2Fkernel%2Fstable.git [PATCH] NTFS: Critical bug fix (affects MIPS and possibly others) It fixes a crash in NTFS on architectures where flush_dcache_page() is a real function. I never noticed this as all my testing is done on i386 where flush_dcache_page() is NULL. http://bugzilla.kernel.org/show_bug.cgi?id=6700 Many thanks to Pauline Ng for the detailed bug report and analysis! Signed-off-by: Anton Altaparmakov Cc: Signed-off-by: Andrew Morton Signed-off-by: Chris Wright --- diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index c63a83e8da98b..36e1e136bb0c6 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -1484,14 +1484,15 @@ static inline void ntfs_flush_dcache_pages(struct page **pages, unsigned nr_pages) { BUG_ON(!nr_pages); + /* + * Warning: Do not do the decrement at the same time as the call to + * flush_dcache_page() because it is a NULL macro on i386 and hence the + * decrement never happens so the loop never terminates. + */ do { - /* - * Warning: Do not do the decrement at the same time as the - * call because flush_dcache_page() is a NULL macro on i386 - * and hence the decrement never happens. - */ + --nr_pages; flush_dcache_page(pages[nr_pages]); - } while (--nr_pages > 0); + } while (nr_pages > 0); } /**