From: lpsolit%gmail.com <>
Date: Thu, 30 Jun 2005 04:54:49 +0000 (+0000)
Subject: Bug 202278: Quips are escaped now, no need for HTML-like blocking - Patch by Frédéric... 
X-Git-Tag: bugzilla-2.20rc1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3277ac732e00522fbe403350b24054361413aca1;p=thirdparty%2Fbugzilla.git

Bug 202278: Quips are escaped now, no need for HTML-like blocking - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=myk
---

diff --git a/quips.cgi b/quips.cgi
index 766d1a7921..d811ee5fe4 100755
--- a/quips.cgi
+++ b/quips.cgi
@@ -79,7 +79,6 @@ if ($action eq "add") {
       (Param('quip_list_entry_control') eq "open") || (UserInGroup('admin')) || 0;
     my $comment = $cgi->param("quip");
     $comment || ThrowUserError("need_quip");
-    $comment !~ m/</ || ThrowUserError("no_html_in_quips");
 
     SendSQL("INSERT INTO quips (userid, quip, approved) VALUES " .
            '(' . $userid . ', ' . SqlQuote($comment) . ', ' . $approved . ')');
diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl
index f19ecbe333..2696ede15e 100644
--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -858,11 +858,6 @@
     and an error
     occurred opening yesterday's dupes file: [% error_msg FILTER html %].
 
-  [% ELSIF error == "no_html_in_quips" %]
-    [% title = "No HTML In Quips" %]
-    Sorry - for security reasons, support for HTML tags has been turned off
-    in quips.
-
   [% ELSIF error == "no_new_quips" %]
     [% title = "No New Quips" %]
     This site does not permit the addition of new quips.