From: jouni%heikniemi.net <>
Date: Fri, 23 Jul 2004 12:07:24 +0000 (+0000)
Subject: Bug 252329: Returning to buglist after an empty fulltext search causes code error
X-Git-Tag: bugzilla-2.18rc2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=329afe7534193cf920d2ae636c946394806f240c;p=thirdparty%2Fbugzilla.git

Bug 252329: Returning to buglist after an empty fulltext search causes code error
r=kiko, a=justdave
---

diff --git a/buglist.cgi b/buglist.cgi
index 28993cbec2..1e71d5238e 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -591,9 +591,17 @@ my @selectnames = map($columns->{$_}->{'name'}, @selectcolumns);
 ################################################################################
 
 # Add to the query some instructions for sorting the bug list.
-if ($::COOKIE{'LASTORDER'} && (!$order || $order =~ /^reuse/i)) {
-    $order = $::COOKIE{'LASTORDER'};
-    $order_from_cookie = 1;
+
+# First check if we'll want to reuse the last sorting order; that happens if
+# the order is not defined or its value is "reuse last sort"
+if (!$order || $order =~ /^reuse/i) {
+    if ($::COOKIE{'LASTORDER'}) {
+      $order = $::COOKIE{'LASTORDER'};
+      $order_from_cookie = 1;
+    }
+    else {
+      $order = '';  # Remove possible "reuse" identifier as unnecessary
+    }
 }
 
 my $db_order = "";  # Modified version of $order for use with SQL query