From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Thu, 23 Jul 2026 11:24:57 +0000 (+0200)
Subject: Two coverity fixes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32a1e9defadff9601ac66798c95f128f66cc6f21;p=thirdparty%2Fpdns.git

Two coverity fixes

I hope compilers are smart enough to see that the bottom of the function cannot be reached
(clang is happy with the missing return).

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/iputils.cc b/pdns/iputils.cc
index 44d458790c..5b0e91f56c 100644
--- a/pdns/iputils.cc
+++ b/pdns/iputils.cc
@@ -473,7 +473,7 @@ pdns::expected<size_t, int> sendMsgWithOptions(int socketDesc, const void* buffe
     }
   } while (true);
 
-  return 0;
+  // NOTREACHED
 }
 
 template class NetmaskTree<bool, Netmask>;
diff --git a/pdns/query-local-address.cc b/pdns/query-local-address.cc
index f5b5a4d3b6..32a15a20f9 100644
--- a/pdns/query-local-address.cc
+++ b/pdns/query-local-address.cc
@@ -102,7 +102,7 @@ namespace pdns
         itf = Interface{ parts.at(1), idx };
       }
 
-      AddressAndInterface tmp{ComboAddress{addr}, itf};
+      AddressAndInterface tmp{ComboAddress{addr}, std::move(itf)};
       if (tmp.d_address.isIPv4()) {
         g_localQueryAddresses4.emplace_back(std::move(tmp));
         continue;