From: Jakub Jelinek Date: Thu, 28 Nov 2024 13:54:42 +0000 (+0100) Subject: testsuite: Fix up pr116675.c test [PR116675] X-Git-Tag: basepoints/gcc-16~3799 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32a3f46ca543726196371a6f2a5d06feb31aa92d;p=thirdparty%2Fgcc.git testsuite: Fix up pr116675.c test [PR116675] The test uses dg-do run and scan-assembler* at the same time, that obviously doesn't work when pr116675.s isn't created at all, so one gets PASS: gcc.target/i386/pr116675.c execution test gcc.target/i386/pr116675.c: output file does not exist UNRESOLVED: gcc.target/i386/pr116675.c scan-assembler-times pand 4 gcc.target/i386/pr116675.c: output file does not exist UNRESOLVED: gcc.target/i386/pr116675.c scan-assembler-times pandn 4 gcc.target/i386/pr116675.c: output file does not exist UNRESOLVED: gcc.target/i386/pr116675.c scan-assembler-times por 4 The usual way to handle that is adding -save-temps option. The test FAILs after that change though, for simple reason, the pand regex doesn't match just pand instructions, but also the pandn ones. I've added \t there to make sure it matches only pand. Though, wonder if it wouldn't be safer to split the test into two, one with just the 4 functions (why noinline, noclone rather than noipa, btw?), that one would be dg-do compile and have the scan-assembler* directives, and then another one which includes the first one and is dg-do run and contains the runtime checking of those. In any case, I've committed this as obvious. 2024-11-28 Jakub Jelinek PR target/116675 * gcc.target/i386/pr116675.c: Add -save-temps to dg-options. Scan for pand\t rather than pand. --- diff --git a/gcc/testsuite/gcc.target/i386/pr116675.c b/gcc/testsuite/gcc.target/i386/pr116675.c index e463dd8415f5..f108b680f6d0 100644 --- a/gcc/testsuite/gcc.target/i386/pr116675.c +++ b/gcc/testsuite/gcc.target/i386/pr116675.c @@ -1,6 +1,6 @@ /* { dg-do run } */ -/* { dg-options "-O2 -msse2 -mno-ssse3" } */ -/* { dg-final { scan-assembler-times "pand" 4 } } */ +/* { dg-options "-O2 -msse2 -mno-ssse3 -save-temps" } */ +/* { dg-final { scan-assembler-times "pand\t" 4 } } */ /* { dg-final { scan-assembler-times "pandn" 4 } } */ /* { dg-final { scan-assembler-times "por" 4 } } */