From: Frédéric Buclin <LpSolit@gmail.com>
Date: Tue, 16 Aug 2011 01:44:09 +0000 (+0200)
Subject: Bug 678772: version.pm 0.92 and newer forbids negative values, making checksetup... 
X-Git-Tag: bugzilla-4.2rc1~89
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32ca131f3518873f80690b8bf51b32337c422927;p=thirdparty%2Fbugzilla.git

Bug 678772: version.pm 0.92 and newer forbids negative values, making checksetup.pl to fail
r/a=mkanat
---

diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 8825eb3a74..ef4bf3d22c 100644
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -717,8 +717,9 @@ sub _checking_for {
     # show "ok" or "not found".
     if (exists $params->{found}) {
         my $found_string;
-        # We do a string compare in case it's non-numeric.
-        if ($found and $found eq "-1") {
+        # We do a string compare in case it's non-numeric. We make sure
+        # it's not a version object as negative versions are forbidden.
+        if ($found && !ref($found) && $found eq '-1') {
             $found_string = install_string('module_not_found');
         }
         elsif ($found) {