From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Thu, 25 Apr 2024 16:00:20 +0000 (+0100)
Subject: insane: Error for S == WORKDIR
X-Git-Tag: uninative-4.6~515
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32cba1cc916a;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git

insane: Error for S == WORKDIR

Where a recipe uses WORKDIR as S, exit with a fatal error since the
code is no longer safe for this layout.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 03ac06b102f..eeef43d00e2 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1602,6 +1602,11 @@ python () {
     if prog.search(pn):
         oe.qa.handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d)
 
+    sourcedir = d.getVar("S")
+    workdir = d.getVar("WORKDIR")
+    if sourcedir == workdir:
+        bb.fatal("Using S = ${WORKDIR} is no longer supported")
+
     # Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder
     # why it doesn't work.
     if (d.getVar(d.expand('DEPENDS:${PN}'))):