From: Alexandre Oliva <oliva@adacore.com>
Date: Wed, 27 Nov 2024 09:27:12 +0000 (-0300)
Subject: ifcombine: skip fallback conjunction on noncontiguous blocks
X-Git-Tag: basepoints/gcc-16~3836
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32f6485849c8268f5c7bd8454702bfec369768b1;p=thirdparty%2Fgcc.git

ifcombine: skip fallback conjunction on noncontiguous blocks

When everything else fails, if enabled by the target or by a
parameter, and when other requirements are satisfied, ifcombine
generates an AND of both conditions.

That may be good for contiguous conditions, but it's unlikely to be an
optimization when the blocks are separate.

Add contiguity to the set of requirements for this fallback
transformation.


for  gcc/ChangeLog

	* tree-ssa-ifcombine.cc (ifcombine_ifandif): Avoid fallback
	conjunction of noncontiguous conditions.
---

diff --git a/gcc/tree-ssa-ifcombine.cc b/gcc/tree-ssa-ifcombine.cc
index 9a4c6a3f4d1d..e389b12aa37d 100644
--- a/gcc/tree-ssa-ifcombine.cc
+++ b/gcc/tree-ssa-ifcombine.cc
@@ -973,6 +973,10 @@ ifcombine_ifandif (basic_block inner_cond_bb, bool inner_inv,
 					    gimple_cond_rhs (outer_cond),
 					    gimple_bb (outer_cond))))
 	{
+	  /* Only combine conditions in this fallback case if the blocks are
+	     neighbors.  */
+	  if (single_pred (inner_cond_bb) != outer_cond_bb)
+	    return false;
 	  tree t1, t2;
 	  bool logical_op_non_short_circuit = LOGICAL_OP_NON_SHORT_CIRCUIT;
 	  if (param_logical_op_non_short_circuit != -1)