From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Thu, 22 Dec 2022 11:55:05 +0000 (+0200)
Subject: login-common: Disconnect reason - Move auth_process_comm_fail check earlier
X-Git-Tag: 2.4.0~2906
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3308b03d60c41a35ad7f5984489daf4d0d6931dd;p=thirdparty%2Fdovecot%2Fcore.git

login-common: Disconnect reason - Move auth_process_comm_fail check earlier

Likely doesn't matter, but this is more important reason to be logged than
the ones coming later.
---

diff --git a/src/login-common/client-common.c b/src/login-common/client-common.c
index a299d54734..8194c144d1 100644
--- a/src/login-common/client-common.c
+++ b/src/login-common/client-common.c
@@ -1136,6 +1136,9 @@ const char *client_get_extra_disconnect_reason(struct client *client)
 			(unsigned int)(ioloop_time - client->created.tv_sec));
 	}
 
+	if (client->auth_process_comm_fail)
+		return "auth process communication failure";
+
 	if (client->auth_client_continue_pending && client->auth_attempts == 1) {
 		return t_strdup_printf("client didn't finish SASL auth, "
 				       "waited %u secs", auth_secs);
@@ -1150,8 +1153,6 @@ const char *client_get_extra_disconnect_reason(struct client *client)
 	}
 	if (client->auth_aborted_by_client && client->auth_attempts == 1)
 		return "auth aborted by client";
-	if (client->auth_process_comm_fail)
-		return "auth process communication failure";
 
 	if (client->auth_nologin_referral)
 		return "auth referral";