From: Trenton Holmes <trenton.holmes@psware.com>
Date: Wed, 13 Apr 2022 20:57:39 +0000 (-0700)
Subject: Adds some logging so we know which login method has failed
X-Git-Tag: v1.8.0-beta.rc1~148^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=330e47f0b794e0b9a949de2a86a04d7477f2a5b2;p=thirdparty%2Fpaperless-ngx.git

Adds some logging so we know which login method has failed
---

diff --git a/src/paperless_mail/mail.py b/src/paperless_mail/mail.py
index 4f41126cfa..2b3267aeb3 100644
--- a/src/paperless_mail/mail.py
+++ b/src/paperless_mail/mail.py
@@ -167,6 +167,7 @@ class MailAccountHandler(LoggingMixin):
                 M.login(account.username, account.password)
 
             except UnicodeEncodeError:
+                self.log("debug", "Falling back to AUTH=PLAIN")
                 try:
                     # rfc2595 section 6 - PLAIN SASL mechanism
                     client: IMAP4 = M.client
@@ -184,8 +185,13 @@ class MailAccountHandler(LoggingMixin):
                     # Need to transition out of AUTH state to SELECTED
                     M.folder.set("INBOX")
                 except Exception:
+                    self.log(
+                        "error",
+                        "Unable to authenticate with mail server using AUTH=PLAIN",
+                    )
                     raise MailError(f"Error while authenticating account {account}")
             except Exception:
+                self.log("error", "Unable to authenticate with mail server")
                 raise MailError(f"Error while authenticating account {account}")
 
             self.log(
diff --git a/src/paperless_mail/tests/test_mail.py b/src/paperless_mail/tests/test_mail.py
index 352c3f3696..85fda29758 100644
--- a/src/paperless_mail/tests/test_mail.py
+++ b/src/paperless_mail/tests/test_mail.py
@@ -869,7 +869,7 @@ class TestMail(DirectoriesMixin, TestCase):
         """
         GIVEN:
             - Mail account with password containing non-ASCII characters
-            - Incorrect password alue
+            - Incorrect password value
         THEN:
             - Should raise a MailError for the account
         """