From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 19 Sep 2025 09:37:37 +0000 (+0200)
Subject: dnsdist: Appease clang-tidy
X-Git-Tag: rec-5.4.0-alpha1~253^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=332f2c37a7a7a8c07824ef93a0a796e39694bcfe;p=thirdparty%2Fpdns.git

dnsdist: Appease clang-tidy

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
index 93bc20c323..a57c1eb36e 100644
--- a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
+++ b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
@@ -322,8 +322,8 @@ void TCPConnectionToBackend::handleReconnectionAttempt(std::shared_ptr<TCPConnec
         if (conn->d_state == State::sendingQueryToBackend) {
           /* we need to edit this query so it has the correct ID */
           auto query = std::move(conn->d_currentQuery);
-          uint16_t id = conn->d_highestStreamID;
-          prepareQueryForSending(query.d_query, id, ConnectionState::needProxy);
+          uint16_t streamId = conn->d_highestStreamID;
+          prepareQueryForSending(query.d_query, streamId, ConnectionState::needProxy);
           conn->d_currentQuery = std::move(query);
         }
 
@@ -340,8 +340,8 @@ void TCPConnectionToBackend::handleReconnectionAttempt(std::shared_ptr<TCPConnec
               TCPResponse response(std::move(pending.second.d_query));
               pending.second.d_sender->notifyIOError(now, std::move(response));
             }
-            catch (const std::exception& e) {
-              vinfolog("Got an exception while notifying: %s", e.what());
+            catch (const std::exception& exp) {
+              vinfolog("Got an exception while notifying: %s", exp.what());
             }
             catch (...) {
               vinfolog("Got exception while notifying");
@@ -369,7 +369,7 @@ void TCPConnectionToBackend::handleReconnectionAttempt(std::shared_ptr<TCPConnec
         connectionDied = false;
       }
     }
-    catch (const std::exception& e) {
+    catch (const std::exception& exp) {
       // reconnect might throw on failure, let's ignore that, we just need to know
       // it failed
     }