From: Volker Lendecke <vl@samba.org>
Date: Tue, 7 Sep 2021 13:04:16 +0000 (+0200)
Subject: samba_dnsupdate: Fix deprecation warnings
X-Git-Tag: ldb-2.5.0~765
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3347bfce9ee8b20c09dec2c0c5eb69b0c4bdb743;p=thirdparty%2Fsamba.git

samba_dnsupdate: Fix deprecation warnings

We should not call samba-tool with -k anymore

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/scripting/bin/samba_dnsupdate b/source4/scripting/bin/samba_dnsupdate
index 518bb898d33..de39ac39cad 100755
--- a/source4/scripting/bin/samba_dnsupdate
+++ b/source4/scripting/bin/samba_dnsupdate
@@ -589,8 +589,8 @@ def call_samba_tool(d, op="add", zone=None):
     try:
         cmd = cmd_dns()
         if opts.verbose:
-            print("Calling samba-tool dns %s -k no -P %s" % (op, args))
-        ret = cmd._run("dns", op, "-k", "no", "-P", *args)
+            print(f'Calling samba-tool dns {op} --use-kerberos off -P {args}')
+        ret = cmd._run("dns", op, "--use-kerberos", "off", "-P", *args)
         if ret == -1:
             if opts.fail_immediately:
                 sys.exit(1)