From: Glenn Washburn <development@efficientek.com>
Date: Fri, 5 Mar 2021 00:22:35 +0000 (-0600)
Subject: disk/dmraid_nvidia: Format string error in grub_error()
X-Git-Tag: grub-2.06-rc1~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=334c0ef3d0cea602c84d7c161e4aa2130acb80ad;p=thirdparty%2Fgrub.git

disk/dmraid_nvidia: Format string error in grub_error()

The grub_error() has a format string expecting two arguments, but only one
provided. According to the comments in the struct grub_nv_super definition,
the version field looks like a version number where major.minor is encoded
as each a byte in the two-byte short.

Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---

diff --git a/grub-core/disk/dmraid_nvidia.c b/grub-core/disk/dmraid_nvidia.c
index 4d2fb04d1..6372663e6 100644
--- a/grub-core/disk/dmraid_nvidia.c
+++ b/grub-core/disk/dmraid_nvidia.c
@@ -122,7 +122,7 @@ grub_dmraid_nv_detect (grub_disk_t disk,
   if (sb.version != NV_VERSION)
     {
       grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET,
-		  "unknown version: %d.%d", sb.version);
+		  "unknown version: %d.%d", sb.version >> 8, sb.version & 0xFF);
       return NULL;
     }