From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 17 Mar 2015 16:44:50 +0000 (+0100)
Subject: qemuGetDHCPInterfaces: Don't leak @network
X-Git-Tag: v1.2.14-rc1~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3353c7c40ad1c586904e33eee57bba4da1706e5e;p=thirdparty%2Flibvirt.git

qemuGetDHCPInterfaces: Don't leak @network

The function needs a pointer to the network to get list of DHCP
leases. The pointer is obtained via virNetworkLookupByName() which
requires callers to free the returned network once no longer needed.
Otherwise it's leaked.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e0b672357f..ed6764d548 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -19652,7 +19652,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom,
     int n_leases = 0;
     size_t i, j;
     size_t ifaces_count = 0;
-    virNetworkPtr network;
+    virNetworkPtr network = NULL;
     char macaddr[VIR_MAC_STRING_BUFLEN];
     virDomainInterfacePtr iface = NULL;
     virNetworkDHCPLeasePtr *leases = NULL;
@@ -19670,6 +19670,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom,
             continue;
 
         virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr);
+        virObjectUnref(network);
         network = virNetworkLookupByName(dom->conn,
                                          vm->def->nets[i]->data.network.name);
 
@@ -19720,6 +19721,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom,
     rv = ifaces_count;
 
  cleanup:
+    virObjectUnref(network);
     if (leases) {
         for (i = 0; i < n_leases; i++)
             virNetworkDHCPLeaseFree(leases[i]);