From: Thierry FOURNIER <tfournier@arpalert.org>
Date: Thu, 26 Nov 2015 18:48:04 +0000 (+0100)
Subject: BUG/MINOR: stream: bad return code
X-Git-Tag: v1.7-dev2~168
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=337eae188206e2a6f9f94c613c1a5e8070391ec8;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stream: bad return code

In error case, we expect the enum ACT_RET_PRS_ERR, but the
function "stream_parse_use_service()" returns "-1"

This patch must be backported in 1.6
---

diff --git a/src/stream.c b/src/stream.c
index e98ba9f2d2..0d18f9c2fd 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -3302,7 +3302,7 @@ static enum act_parse_ret stream_parse_use_service(const char **args, int *cur_a
 	/* Check if the service name exists. */
 	if (*(args[*cur_arg]) == 0) {
 		memprintf(err, "'%s' expects a service name.", args[0]);
-		return -1;
+		return ACT_RET_PRS_ERR;
 	}
 
 	/* lookup for keyword corresponding to a service. */