From: Nick Porter <nick@portercomputing.co.uk>
Date: Tue, 30 May 2023 11:23:25 +0000 (+0100)
Subject: Fix segfault in redis_ippool_tool stats
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=337f52c04ec89eb15406a8b47efc2846c5bbc911;p=thirdparty%2Ffreeradius-server.git

Fix segfault in redis_ippool_tool stats
---

diff --git a/src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c b/src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c
index 44cf27d5f17..12b9ea48d85 100644
--- a/src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c
+++ b/src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c
@@ -862,12 +862,12 @@ static ssize_t driver_get_pools(TALLOC_CTX *ctx, uint8_t **out[], void *instance
 	/*
 	 *	Sort the results
 	 */
-	{
+	if (used > 1) {
 		uint8_t const **to_sort;
 
 		memcpy(&to_sort, &result, sizeof(to_sort));
 
-		fr_quick_sort((void const **)to_sort, 0, used, pool_cmp);
+		fr_quick_sort((void const **)to_sort, 0, used - 1, pool_cmp);
 	}
 
 	*out = talloc_array(ctx, uint8_t *, used);