From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 29 Aug 2012 16:40:03 +0000 (+0200)
Subject: Check for NULL secret on dynamic clients
X-Git-Tag: release_2_2_0~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3385c2f5235e7d2320f5e5a5f3e66fa27e222225;p=thirdparty%2Ffreeradius-server.git

Check for NULL secret on dynamic clients
---

diff --git a/src/main/client.c b/src/main/client.c
index 59a14d110cf..dbfaa1e6e9d 100644
--- a/src/main/client.c
+++ b/src/main/client.c
@@ -1093,6 +1093,13 @@ RADCLIENT *client_create(RADCLIENT_LIST *clients, REQUEST *request)
 		goto error;
 	}
 
+	if (!c->secret || !*c->secret) {
+		DEBUG("- Cannot add client %s: No secret was specified.",
+		      ip_ntoh(&request->packet->src_ipaddr,
+			      buffer, sizeof(buffer)));
+		goto error;
+	}
+
 	if (!client_validate(clients, request->client, c)) {
 		return NULL;
 	}