From: bugzilla%glob.com.au <>
Date: Fri, 6 May 2005 21:16:54 +0000 (+0000)
Subject: Bug 292821: "Attempt to free unreferenced scalar" running checksetup
X-Git-Tag: bugzilla-2.19.3~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33993daf6e2e336cfa08cb20827d017702c0ab32;p=thirdparty%2Fbugzilla.git

Bug 292821: "Attempt to free unreferenced scalar" running checksetup
Patch By Byron Jones <bugzilla@glob.com.au> r=mkanat,r=vladd,a=justdave
---

diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm
index 2ca0f52e64..17c3d6b9e6 100644
--- a/Bugzilla/DB/Mysql.pm
+++ b/Bugzilla/DB/Mysql.pm
@@ -492,8 +492,12 @@ sub bz_column_info_real {
     # so we have to get all the columns on the table and find 
     # the one we want.
     my $info_sth = $self->column_info(undef, undef, $table, '%');
-    my $all_cols = $info_sth->fetchall_hashref("COLUMN_NAME");
-    my $col_data = $all_cols->{$column};
+
+    # Don't use fetchall_hashref as there's a Win32 DBI bug (292821)
+    my $col_data;
+    while ($col_data = $info_sth->fetchrow_hashref) {
+        last if $col_data->{'COLUMN_NAME'} eq $column;
+    }
 
     if (!defined $col_data) {
         return undef;