From: Willy Tarreau <w@1wt.eu>
Date: Thu, 25 Oct 2018 11:49:49 +0000 (+0200)
Subject: MINOR: stream-int: don't needlessly call tasklet_wakeup() in stream_int_chk_snd_conn()
X-Git-Tag: v1.9-dev5~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33a09a5f2a74a06089081fc4dc499d979d78265e;p=thirdparty%2Fhaproxy.git

MINOR: stream-int: don't needlessly call tasklet_wakeup() in stream_int_chk_snd_conn()

This one was added by commit 53216e7db ("MEDIUM: connections: Don't
directly mess with the polling from the upper layers.") after the
removal of the conditional cs_want_send() call. But after analysis
it turned out that it's not needed since the si_cs_send() call will
either succeed or subscribe.
---

diff --git a/src/stream_interface.c b/src/stream_interface.c
index 4fd23c3a4d..e7ba722886 100644
--- a/src/stream_interface.c
+++ b/src/stream_interface.c
@@ -995,7 +995,7 @@ static void stream_int_chk_snd_conn(struct stream_interface *si)
 
 	if (!(si->wait_event.wait_reason & SUB_CAN_SEND) && co_data(si_oc(si)))
 		si_cs_send(cs);
-	tasklet_wakeup(si->wait_event.task);
+
 	if (cs->flags & CS_FL_ERROR || cs->conn->flags & CO_FL_ERROR) {
 		/* Write error on the file descriptor */
 		si->flags |= SI_FL_ERR;