From: Hugo Landau <hlandau@openssl.org>
Date: Mon, 18 Dec 2023 07:30:02 +0000 (+0000)
Subject: Minor fixes
X-Git-Tag: openssl-3.3.0-alpha1~398
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33ca07637246c832b91d60935a1a2fdf02653a02;p=thirdparty%2Fopenssl.git

Minor fixes

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22674)
---

diff --git a/include/internal/quic_port.h b/include/internal/quic_port.h
index 81811b01107..bcb578c3f8d 100644
--- a/include/internal/quic_port.h
+++ b/include/internal/quic_port.h
@@ -70,8 +70,9 @@ void ossl_quic_port_free(QUIC_PORT *port);
 QUIC_CHANNEL *ossl_quic_port_create_outgoing(QUIC_PORT *port, SSL *tls);
 
 /*
- * Create an incoming channel using this port. XXX for temporary TSERVER use
- * only - will be removed.
+ * Create an incoming channel using this port.
+ *
+ * TODO(QUIC SERVER): temporary TSERVER use only - will be removed.
  */
 QUIC_CHANNEL *ossl_quic_port_create_incoming(QUIC_PORT *port, SSL *tls);
 
diff --git a/ssl/quic/quic_port.c b/ssl/quic/quic_port.c
index b4e2deeb84d..9976862138c 100644
--- a/ssl/quic/quic_port.c
+++ b/ssl/quic/quic_port.c
@@ -90,10 +90,9 @@ static int port_init(QUIC_PORT *port)
     port->rx_short_dcid_len = (unsigned char)rx_short_dcid_len;
     port->tx_init_dcid_len  = INIT_DCID_LEN;
     port->state             = QUIC_PORT_STATE_RUNNING;
-    if (port->engine != NULL) {
-        ossl_list_port_insert_tail(&port->engine->port_list, port);
-        port->on_engine_list    = 1;
-    }
+
+    ossl_list_port_insert_tail(&port->engine->port_list, port);
+    port->on_engine_list    = 1;
     return 1;
 
 err: