From: Michael Adam <obnox@samba.org>
Date: Wed, 24 Sep 2008 20:19:26 +0000 (+0200)
Subject: [s3]loadparm: fix memory error - free the right param_opt->list in copy_service.
X-Git-Tag: samba-4.0.0alpha6~769^2~228^2~133
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33d18c76f1bf5e10b52e873af5b29fabd1db7f3c;p=thirdparty%2Fsamba.git

[s3]loadparm: fix memory error - free the right param_opt->list in copy_service.

Michael
---

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 74dff837c01..dbfd5853f51 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -6487,7 +6487,7 @@ static void copy_service(struct service *pserviceDest, struct service *pserviceS
 			/* If we already have same option, override it */
 			if (strwicmp(pdata->key, data->key) == 0) {
 				string_free(&pdata->value);
-				TALLOC_FREE(data->list);
+				TALLOC_FREE(pdata->list);
 				pdata->value = SMB_STRDUP(data->value);
 				not_added = False;
 				break;