From: Olivier Houchard <ohouchard@haproxy.com>
Date: Thu, 15 Mar 2018 16:48:49 +0000 (+0100)
Subject: BUG/MINOR: seemless reload: Fix crash when an interface is specified.
X-Git-Tag: v1.9-dev1~370
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33e083c92e883963beed72ceaea8d12562a7a7ff;p=thirdparty%2Fhaproxy.git

BUG/MINOR: seemless reload: Fix crash when an interface is specified.

When doing a seemless reload, while receiving the sockets from the old process
the new process will die if the socket has been bound to a specific
interface.
This happens because the code that tries to parse the informations bogusly
try to set xfer_sock->namespace, while it should be setting wfer_sock->iface.

This should be backported to 1.8.
---

diff --git a/src/haproxy.c b/src/haproxy.c
index 0c823c4979..d5235ebaf1 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -1180,7 +1180,7 @@ static int get_old_sockets(const char *unixsocket)
 				goto out;
 			}
 			memcpy(xfer_sock->iface, &tmpbuf[curoff], len);
-			xfer_sock->namespace[len] = 0;
+			xfer_sock->iface[len] = 0;
 			curoff += len;
 		}
 		if (curoff + sizeof(int) > maxoff) {