From: Brian Rak Date: Thu, 30 Nov 2023 16:30:26 +0000 (+0000) Subject: Update minor code/doc nits X-Git-Tag: dnsdist-1.9.0~7^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33e306dc43da7bf85d52749ce5d330cf7fb7bc14;p=thirdparty%2Fpdns.git Update minor code/doc nits --- diff --git a/docs/lua-records/functions.rst b/docs/lua-records/functions.rst index fc4a4fd68a..4fbab90bcc 100644 --- a/docs/lua-records/functions.rst +++ b/docs/lua-records/functions.rst @@ -237,7 +237,8 @@ Record creation functions :param values: table of weight, string (such as IPv4 or IPv6 address). This allows basic persistent load balancing across a number of backends. It means that - test.example.com will always resolve to the same IP, but test2.example.com may go elsewhere. + test.mydomain.example.com will always resolve to the same IP, but test2.mydomain.example.com + may go elsewhere. This function is only useful for wildcard records. This works similar to round-robin load balancing, but has the advantage of making traffic for the same domain always end up on the same server which can help cache hit rates. @@ -246,7 +247,7 @@ Record creation functions An example:: - mydomain.example.com IN LUA A ("picknamehashed({ " + *.mydomain.example.com IN LUA A ("picknamehashed({ " " {15, "192.0.2.1"}, " " {100, "198.51.100.5"} " "}) ") diff --git a/regression-tests.auth-py/test_LuaRecords.py b/regression-tests.auth-py/test_LuaRecords.py index 1164af67d5..b48566cf98 100644 --- a/regression-tests.auth-py/test_LuaRecords.py +++ b/regression-tests.auth-py/test_LuaRecords.py @@ -801,16 +801,16 @@ createforward6.example.org. 3600 IN NS ns2.example.org. queries = [ { + 'query': dns.message.make_query('test.namehashed.example.org', 'A'), 'expected': dns.rrset.from_text('test.namehashed.example.org.', 0, dns.rdataclass.IN, 'A', '1.2.3.4'), - 'query': dns.message.make_query('test.namehashed.example.org', 'A') }, { + 'query': dns.message.make_query('test2.namehashed.example.org', 'A'), 'expected': dns.rrset.from_text('test2.namehashed.example.org.', 0, dns.rdataclass.IN, 'A', '4.3.2.1'), - 'query': dns.message.make_query('test2.namehashed.example.org', 'A') } ] for query in queries :