From: Corey Farrell <git@cfware.com>
Date: Fri, 6 Oct 2017 01:23:31 +0000 (-0400)
Subject: main/strings: Fix uninitialized value.
X-Git-Tag: 14.7.0-rc1~27^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3421b1de27da1229bd41cc5a65083231e4b60881;p=thirdparty%2Fasterisk.git

main/strings: Fix uninitialized value.

ast_strings_match uses sscanf and checks for non-zero return to verify a
token was parsed. This is incorrect as sscanf returns EOF (-1) for errors.

ASTERISK-27318 #close

Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1
---

diff --git a/main/strings.c b/main/strings.c
index 19aa2d373b..3a333239c2 100644
--- a/main/strings.c
+++ b/main/strings.c
@@ -314,7 +314,7 @@ regex:
 	}
 
 equals:
-	scan_numeric = (sscanf(left, "%lf", &left_num) && sscanf(internal_right, "%lf", &right_num));
+	scan_numeric = (sscanf(left, "%lf", &left_num) > 0 && sscanf(internal_right, "%lf", &right_num) > 0);
 
 	if (internal_op[0] == '=') {
 		if (ast_strlen_zero(left) && ast_strlen_zero(internal_right)) {