From: Mark Andrews <marka@isc.org>
Date: Thu, 13 Aug 2020 02:30:04 +0000 (+1000)
Subject: TLSA: fix fromwire length checks
X-Git-Tag: v9.17.5~50^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3429c35f52be9dfea69b96fda7d5b7fe804614a5;p=thirdparty%2Fbind9.git

TLSA: fix fromwire length checks
---

diff --git a/lib/dns/rdata/generic/tlsa_52.c b/lib/dns/rdata/generic/tlsa_52.c
index 1140bc01cd9..5aa6ccac56f 100644
--- a/lib/dns/rdata/generic/tlsa_52.c
+++ b/lib/dns/rdata/generic/tlsa_52.c
@@ -128,7 +128,8 @@ generic_fromwire_tlsa(ARGS_FROMWIRE) {
 
 	isc_buffer_activeregion(source, &sr);
 
-	if (sr.length < 3) {
+	/* Usage(1), Selector(1), Type(1), Data(1+) */
+	if (sr.length < 4) {
 		return (ISC_R_UNEXPECTEDEND);
 	}