From: lpsolit%gmail.com <> Date: Thu, 3 Jul 2008 03:44:12 +0000 (+0000) Subject: Bug 365697: email_in.pl is case-sensitive for products due to Bugzilla::User->can_ent... X-Git-Tag: bugzilla-3.2rc1~35 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3432af0569ddecd5f76bf4bcf29a0c45f6a19f0d;p=thirdparty%2Fbugzilla.git Bug 365697: email_in.pl is case-sensitive for products due to Bugzilla::User->can_enter_product - Patch by Frédéric Buclin r/a=mkanat --- diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 5f9e2228c4..ddf8137037 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -680,9 +680,10 @@ sub can_enter_product { return unless $warn == THROW_ERROR; ThrowUserError('no_products'); } - trick_taint($product_name); + my $product = new Bugzilla::Product({name => $product_name}); + my $can_enter = - grep($_->name eq $product_name, @{$self->get_enterable_products}); + $product && grep($_->name eq $product->name, @{$self->get_enterable_products}); return 1 if $can_enter; @@ -691,8 +692,6 @@ sub can_enter_product { # Check why access was denied. These checks are slow, # but that's fine, because they only happen if we fail. - my $product = new Bugzilla::Product({name => $product_name}); - # The product could not exist or you could be denied... if (!$product || !$product->user_has_access($self)) { ThrowUserError('entry_access_denied', {product => $product_name});