From: Marek Vavruša <marek.vavrusa@nic.cz>
Date: Thu, 24 Sep 2015 09:42:34 +0000 (+0200)
Subject: rrcache: disabled parent-child diff tests where parent is right
X-Git-Tag: v1.0.0-beta1~53^2~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=345089dcb375090ab9e17613f331b54eb47c8bfe;p=thirdparty%2Fknot-resolver.git

rrcache: disabled parent-child diff tests where parent is right

until RFC2181 credibility is implemented in cache, this behavior breaks
DNSSEC as the parent-side comes first to the cache
disabled this behavior until implemented properly
---

diff --git a/lib/layer/rrcache.c b/lib/layer/rrcache.c
index e6b9f7fda..5da6d032c 100644
--- a/lib/layer/rrcache.c
+++ b/lib/layer/rrcache.c
@@ -184,12 +184,6 @@ static int commit_rr(const char *key, void *val, void *data)
 	   */
 	knot_rrset_t query_rr;
 	knot_rrset_init(&query_rr, rr->owner, rr->type, rr->rclass);
-	if (kr_cache_peek_rr(baton->txn, &query_rr, &drift) == 0) {
-		/* Allow replace if RRSet in the cache is about to expire. */
-		if (!is_expiring(&query_rr, drift)) {
-		        return kr_ok();
-		}
-	}
 	return kr_cache_insert_rr(baton->txn, rr, baton->timestamp);
 }
 
diff --git a/tests/testdata/iter_pcdiff.rpl b/tests/testdata_notimpl/iter_pcdiff.rpl
similarity index 100%
rename from tests/testdata/iter_pcdiff.rpl
rename to tests/testdata_notimpl/iter_pcdiff.rpl
diff --git a/tests/testdata/iter_pcnamerec.rpl b/tests/testdata_notimpl/iter_pcnamerec.rpl
similarity index 100%
rename from tests/testdata/iter_pcnamerec.rpl
rename to tests/testdata_notimpl/iter_pcnamerec.rpl