From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 4 Apr 2025 09:10:30 +0000 (+0200)
Subject: Replace nested if with switch.
X-Git-Tag: dnsdist-2.0.0-alpha2~69^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=348ed1e6dabd8c9f13bd2ba1a8f1b064b3b5d8ab;p=thirdparty%2Fpdns.git

Replace nested if with switch.
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 543c2634cd..47131e91eb 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1591,20 +1591,22 @@ bool PacketHandler::opcodeQueryInner2(DNSPacket& pkt, queryState &state, bool re
 
   if(d_sd.qname==pkt.qdomain) {
     if(!d_dk.isPresigned(d_sd.qname)) {
-      if(pkt.qtype.getCode() == QType::DNSKEY) {
+      switch (pkt.qtype.getCode()) {
+      case QType::DNSKEY:
         if(addDNSKEY(pkt, state.r)) {
           return true;
         }
-      }
-      else if(pkt.qtype.getCode() == QType::CDNSKEY) {
+        break;
+      case QType::CDNSKEY:
         if(addCDNSKEY(pkt,state.r)) {
           return true;
         }
-      }
-      else if(pkt.qtype.getCode() == QType::CDS) {
+        break;
+      case QType::CDS:
         if(addCDS(pkt,state.r)) {
           return true;
         }
+        break;
       }
     }
     if(pkt.qtype.getCode() == QType::NSEC3PARAM) {