From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 20 Jun 2023 12:35:34 +0000 (+0300)
Subject: dict-redis: Fix error handling for failed synchronous commits
X-Git-Tag: 2.4.0~2625
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34a18f5a79bf7eca58e55aff3e1fe69468292d0f;p=thirdparty%2Fdovecot%2Fcore.git

dict-redis: Fix error handling for failed synchronous commits

An error was logged if a synchronous commit failed, but the commit callback
was called with success instead of failure.
---

diff --git a/src/lib-dict/dict-redis.c b/src/lib-dict/dict-redis.c
index 94ba301aa8..82dcf195e7 100644
--- a/src/lib-dict/dict-redis.c
+++ b/src/lib-dict/dict-redis.c
@@ -700,7 +700,9 @@ redis_transaction_commit(struct dict_transaction_context *_ctx, bool async,
 			i_free(ctx);
 			return;
 		}
-		(void)redis_wait(dict);
+		ctx->error = i_strdup(redis_wait(dict));
+		if (ctx->error != NULL)
+			result.ret = DICT_COMMIT_RET_FAILED;
 	} else {
 		callback(&result, context);
 	}