From: Jürg Billeter <j@bitron.ch>
Date: Tue, 15 Sep 2009 08:45:47 +0000 (+0200)
Subject: Report error when trying to pass signal as argument
X-Git-Tag: 0.7.6~69
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34a4aa68931ae8881492840c495532ae831f90cd;p=thirdparty%2Fvala.git

Report error when trying to pass signal as argument

Fixes bug 584350.
---

diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index ff54fbcd1..1527d02d1 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -408,6 +408,10 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
 					// ignore inner error
 					expr.error = true;
 					return false;
+				} else if (arg.value_type is SignalType) {
+					arg.error = true;
+					Report.error (arg.source_reference, "Cannot pass signals as arguments");
+					return false;
 				} else if (arg.value_type == null) {
 					// disallow untyped arguments except for type inference of callbacks
 					if (!(arg.symbol_reference is Method)) {