From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Fri, 25 Sep 2020 00:38:54 +0000 (+0200)
Subject: lib-smtp: smtp-client-command - Make smtp_client_command_fail_reply(NULL, reply)... 
X-Git-Tag: 2.3.18~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34e5a418c19be71a4d3a782ae6d0d9feb62c1c22;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp-client-command - Make smtp_client_command_fail_reply(NULL, reply) a no-op.
---

diff --git a/src/lib-smtp/smtp-client-command.c b/src/lib-smtp/smtp-client-command.c
index dbd7dca1f0..203a4df7f2 100644
--- a/src/lib-smtp/smtp-client-command.c
+++ b/src/lib-smtp/smtp-client-command.c
@@ -292,12 +292,15 @@ void smtp_client_command_fail_reply(struct smtp_client_command **_cmd,
 				    const struct smtp_reply *reply)
 {
 	struct smtp_client_command *cmd = *_cmd, *tmp_cmd;
+
+	if (cmd == NULL)
+		return;
+	*_cmd = NULL;
+	
 	struct smtp_client_connection *conn = cmd->conn;
 	enum smtp_client_command_state state = cmd->state;
 	smtp_client_command_callback_t *callback = cmd->callback;
 
-	*_cmd = NULL;
-
 	if (state >= SMTP_CLIENT_COMMAND_STATE_FINISHED)
 		return;