From: George Koikara (gkoikara) <gkoikara@cisco.com>
Date: Mon, 11 May 2020 08:26:56 +0000 (+0000)
Subject: Merge pull request #2124 in SNORT/snort3 from ~APOORAJ/snort3:race_condition_ftp... 
X-Git-Tag: 3.0.1-4~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34fec22c3c506f4549c690375fed2070a8b1468d;p=thirdparty%2Fsnort3.git

Merge pull request #2124 in SNORT/snort3 from ~APOORAJ/snort3:race_condition_ftp to master

Squashed commit of the following:

commit af8985bba3de4f461d1471cc2bfac4c586cce0fe
Author: Apoorv Raj <apooraj@cisco.com>
Date:   Mon Mar 30 15:15:35 2020 -0400

    ftp_data: fix race condition
---

diff --git a/src/service_inspectors/ftp_telnet/ftp_data.cc b/src/service_inspectors/ftp_telnet/ftp_data.cc
index a75d8a0f5..ccd2731c9 100644
--- a/src/service_inspectors/ftp_telnet/ftp_data.cc
+++ b/src/service_inspectors/ftp_telnet/ftp_data.cc
@@ -104,7 +104,7 @@ static void FTPDataProcess(
     if ( !status )
     {
         IpsPolicy* empty_policy = snort::get_empty_ips_policy(SnortConfig::get_conf());
-        if ( !get_rule_count() || (empty_policy->policy_id == p->flow->ips_policy_id) )
+        if ( empty_policy->policy_id == p->flow->ips_policy_id )
         {
             if ( PacketTracer::is_active() )
                 PacketTracer::log("Whitelisting Flow: FTP data\n");