From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 11 Oct 2023 19:53:44 +0000 (-0400)
Subject: better error messages, so that we know what's going on
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=350ca9b205ba41ec6eb057b48b1daea1c53b93c0;p=thirdparty%2Ffreeradius-server.git

better error messages, so that we know what's going on
---

diff --git a/src/lib/util/pair_legacy.c b/src/lib/util/pair_legacy.c
index dbff76ae290..1410946fb5a 100644
--- a/src/lib/util/pair_legacy.c
+++ b/src/lib/util/pair_legacy.c
@@ -220,11 +220,15 @@ static ssize_t fr_pair_list_afrom_substr(TALLOC_CTX *ctx, fr_dict_attr_t const *
 			if (err == FR_DICT_ATTR_NOTFOUND) {
 				uint8_t const *q;
 
-			notfound:
-				for (q = (uint8_t const *) p; q < (uint8_t const *) end && fr_dict_attr_allowed_chars[*q]; q++) {
-					/* nothing */
+				if (!fr_dict_attr_allowed_chars[(unsigned char) *p]) {
+					fr_strerror_printf("Invalid character '%c' in attribute name at %s", *p, p);
+				} else {
+				notfound:
+					for (q = (uint8_t const *) p; q < (uint8_t const *) end && fr_dict_attr_allowed_chars[*q]; q++) {
+						/* nothing */
+					}
+					fr_strerror_printf("Unknown attribute \"%.*s\" for parent \"%s\"", (int) (q - ((uint8_t const *) p)), p, my_parent->name);
 				}
-				fr_strerror_printf("Unknown attribute \"%.*s\" for parent \"%s\"", (int) (q - ((uint8_t const *) p)), p, my_parent->name);
 			}
 		error:
 			fr_dict_unknown_free(&da_unknown);