From: Diana Clarke <diana.joan.clarke@gmail.com>
Date: Mon, 14 Mar 2011 18:34:44 +0000 (-0400)
Subject: Warn about unicode column having non-unicode default.  See #2079.
X-Git-Tag: rel_0_7b3~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3538e29a219e8e644d2f44c7f499571e5c1fae8e;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Warn about unicode column having non-unicode default.  See #2079.
---

diff --git a/lib/sqlalchemy/schema.py b/lib/sqlalchemy/schema.py
index a6c7544b14..68e8179f94 100644
--- a/lib/sqlalchemy/schema.py
+++ b/lib/sqlalchemy/schema.py
@@ -722,6 +722,14 @@ class Column(SchemaItem, expression.ColumnClause):
             if isinstance(self.default, (ColumnDefault, Sequence)):
                 args.append(self.default)
             else:
+                if getattr(self.type, '_warn_on_bytestring', False):
+                    # Py3K
+                    #if isinstance(self.default, bytes):
+                    # Py2K
+                    if isinstance(self.default, str):
+                    # end Py2K
+                        util.warn("Unicode column received non-unicode "
+                                  "default value.")                    
                 args.append(ColumnDefault(self.default))
 
         if self.server_default is not None: