From: Michal Nowak <mnowak@isc.org>
Date: Thu, 3 Apr 2025 11:38:03 +0000 (+0200)
Subject: Fix check_pid() in runtime system test on FreeBSD
X-Git-Tag: v9.18.37~10^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=353c7f30cf1de43fc92379c91b62f80c5393ff87;p=thirdparty%2Fbind9.git

Fix check_pid() in runtime system test on FreeBSD

The original check_pid() always returned 0 on FreeBSD, even if the
process was still running. This makes the "verifying that named checks
for conflicting named processes" check fail on FreeBSD with TSAN.

(cherry picked from commit 6acaca963d0a8b1715c1e6c6b38eec45b1c5d63c)
---

diff --git a/bin/tests/system/runtime/tests.sh b/bin/tests/system/runtime/tests.sh
index 6ee71bff3af..2df34551047 100644
--- a/bin/tests/system/runtime/tests.sh
+++ b/bin/tests/system/runtime/tests.sh
@@ -62,7 +62,7 @@ run_named() (
 )
 
 check_pid() (
-  return $(! kill -0 "${1}" >/dev/null 2>&1)
+  ! kill -0 "${1}" >/dev/null 2>&1
 )
 
 status=0