From: Alan Modra <amodra@gmail.com>
Date: Tue, 7 Mar 2017 01:50:00 +0000 (+1030)
Subject: Fix ld uninitialized read of script ASSERT data structure
X-Git-Tag: users/ARM/embedded-binutils-2_28-branch-2017q2~145
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=354199c7692c1bed53a2a15f0e4d531457e95f17;p=thirdparty%2Fbinutils-gdb.git

Fix ld uninitialized read of script ASSERT data structure

lang_assignment_statement serves both assignments and asserts.

	* ldlang.c (open_input_bfds): Check that lang_assignment_statement
	is not an assert before referencing defsym.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index fd3e232557d..f4fda0ca3a9 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2017-03-07  Alan Modra  <amodra@gmail.com>
+
+	* ldlang.c (open_input_bfds): Check that lang_assignment_statement
+	is not an assert before referencing defsym.
+
 2017-03-02  Tristan Gingold  <gingold@adacore.com>
 
 	* configure: Regenerate.
diff --git a/ld/ldlang.c b/ld/ldlang.c
index dafc3489fd8..54f160c4db4 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -3377,7 +3377,8 @@ open_input_bfds (lang_statement_union_type *s, enum open_bfd_mode mode)
 #endif
 	  break;
 	case lang_assignment_statement_enum:
-	  if (s->assignment_statement.exp->assign.defsym)
+	  if (s->assignment_statement.exp->type.node_class != etree_assert
+	      && s->assignment_statement.exp->assign.defsym)
 	    /* This is from a --defsym on the command line.  */
 	    exp_fold_tree_no_dot (s->assignment_statement.exp);
 	  break;