From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 28 Aug 2023 01:52:47 +0000 (+1200)
Subject: tests/krb5: Have modified_ticket() not modify its arguments
X-Git-Tag: tevent-0.16.0~756
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=357b520b37f5fd832118f58c1f034c1d64fb7a43;p=thirdparty%2Fsamba.git

tests/krb5: Have modified_ticket() not modify its arguments

Inexplicable behaviour could result when the same arguments were passed
in across multiple calls.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index 8d578bb0b89..536803e7a1f 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -5551,6 +5551,8 @@ class RawKerberosTest(TestCase):
             # A dict containing a key for each checksum type to be created in
             # the PAC.
             checksum_keys = {}
+        else:
+            checksum_keys = dict(checksum_keys)
 
         if include_checksums is None:
             # A dict containing a value for each checksum type; True if the
@@ -5558,6 +5560,8 @@ class RawKerberosTest(TestCase):
             # excluded, or None/not present if the checksum is to be included
             # based on its presence in the original PAC.
             include_checksums = {}
+        else:
+            include_checksums = dict(include_checksums)
 
         # Check that the values passed in by the caller make sense.