From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 16 Aug 2018 17:05:23 +0000 (-0400)
Subject: remove unused detach() function
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35ade974da52172c5a3ebebbb0893cac80fdfa0d;p=thirdparty%2Ffreeradius-server.git

remove unused detach() function
---

diff --git a/src/modules/proto_control/proto_control_tcp.c b/src/modules/proto_control/proto_control_tcp.c
index 19fd89e875d..8f755302033 100644
--- a/src/modules/proto_control/proto_control_tcp.c
+++ b/src/modules/proto_control/proto_control_tcp.c
@@ -535,25 +535,12 @@ static RADCLIENT *mod_client_find(UNUSED void *instance, fr_ipaddr_t const *ipad
 	return client_find(NULL, ipaddr, ipproto);
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_control_tcp_t	*inst = talloc_get_type_abort(instance, proto_control_tcp_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_control_tcp;
 fr_app_io_t proto_control_tcp = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "control_tcp",
 	.config			= tcp_listen_config,
 	.inst_size		= sizeof(proto_control_tcp_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 
 	.default_message_size	= 4096,
diff --git a/src/modules/proto_control/proto_control_unix.c b/src/modules/proto_control/proto_control_unix.c
index 3d829d652e5..1303cb69659 100644
--- a/src/modules/proto_control/proto_control_unix.c
+++ b/src/modules/proto_control/proto_control_unix.c
@@ -1227,25 +1227,12 @@ static RADCLIENT *mod_client_find(void *instance, UNUSED fr_ipaddr_t const *ipad
 	return &inst->radclient;
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_control_unix_t	*inst = talloc_get_type_abort(instance, proto_control_unix_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_control_unix;
 fr_app_io_t proto_control_unix = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "control_unix",
 	.config			= unix_listen_config,
 	.inst_size		= sizeof(proto_control_unix_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 
 	.default_message_size	= 4096,
diff --git a/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c b/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
index 3f46034b7d2..9db7978af0c 100644
--- a/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
+++ b/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
@@ -736,25 +736,12 @@ static RADCLIENT *mod_client_find(UNUSED void *instance, fr_ipaddr_t const *ipad
 	return client_find(NULL, ipaddr, ipproto);
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_dhcpv4_udp_t	*inst = talloc_get_type_abort(instance, proto_dhcpv4_udp_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_dhcpv4_udp;
 fr_app_io_t proto_dhcpv4_udp = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "dhcpv4_udp",
 	.config			= udp_listen_config,
 	.inst_size		= sizeof(proto_dhcpv4_udp_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 	.instantiate		= mod_instantiate,
 
diff --git a/src/modules/proto_radius/proto_radius_tcp.c b/src/modules/proto_radius/proto_radius_tcp.c
index a87e1635696..a3e67b68fa9 100644
--- a/src/modules/proto_radius/proto_radius_tcp.c
+++ b/src/modules/proto_radius/proto_radius_tcp.c
@@ -648,25 +648,12 @@ static RADCLIENT *mod_client_find(UNUSED void *instance, fr_ipaddr_t const *ipad
 	return client_find(NULL, ipaddr, ipproto);
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_radius_tcp_t	*inst = talloc_get_type_abort(instance, proto_radius_tcp_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_radius_tcp;
 fr_app_io_t proto_radius_tcp = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "radius_tcp",
 	.config			= tcp_listen_config,
 	.inst_size		= sizeof(proto_radius_tcp_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 
 	.default_message_size	= 4096,
diff --git a/src/modules/proto_radius/proto_radius_udp.c b/src/modules/proto_radius/proto_radius_udp.c
index 22714a329b3..4e45f214217 100644
--- a/src/modules/proto_radius/proto_radius_udp.c
+++ b/src/modules/proto_radius/proto_radius_udp.c
@@ -561,25 +561,12 @@ static RADCLIENT *mod_client_find(void *instance, fr_ipaddr_t const *ipaddr, int
 	return client_find(NULL, ipaddr, ipproto);
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_radius_udp_t	*inst = talloc_get_type_abort(instance, proto_radius_udp_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_radius_udp;
 fr_app_io_t proto_radius_udp = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "radius_udp",
 	.config			= udp_listen_config,
 	.inst_size		= sizeof(proto_radius_udp_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 
 	.default_message_size	= 4096,
diff --git a/src/modules/proto_vmps/proto_vmps_udp.c b/src/modules/proto_vmps/proto_vmps_udp.c
index a702da112f2..1dd3f509ec3 100644
--- a/src/modules/proto_vmps/proto_vmps_udp.c
+++ b/src/modules/proto_vmps/proto_vmps_udp.c
@@ -575,25 +575,12 @@ static RADCLIENT *mod_client_find(void *instance, fr_ipaddr_t const *ipaddr, int
 	return client_find(NULL, ipaddr, ipproto);
 }
 
-#if 0
-static int mod_detach(void *instance)
-{
-	proto_vmps_udp_t	*inst = talloc_get_type_abort(instance, proto_vmps_udp_t);
-
-	if (inst->sockfd >= 0) close(inst->sockfd);
-	inst->sockfd = -1;
-
-	return 0;
-}
-#endif
-
 extern fr_app_io_t proto_vmps_udp;
 fr_app_io_t proto_vmps_udp = {
 	.magic			= RLM_MODULE_INIT,
 	.name			= "vmps_udp",
 	.config			= udp_listen_config,
 	.inst_size		= sizeof(proto_vmps_udp_t),
-//	.detach			= mod_detach,
 	.bootstrap		= mod_bootstrap,
 	.instantiate		= mod_instantiate,