From: Maks Mishin <maks.mishinfz@gmail.com>
Date: Tue, 6 Feb 2024 23:54:03 +0000 (+0300)
Subject: ctrl: Fix fd leak in ctrl_list()
X-Git-Tag: v6.8.0~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35c02157396c847e57f52b5d6d345af2b961a794;p=thirdparty%2Fiproute2.git

ctrl: Fix fd leak in ctrl_list()

if ctrl_list is called with get operation and wrong number
of parameters, it would forget to close the local netlink
handle.

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

diff --git a/genl/ctrl.c b/genl/ctrl.c
index aff922a43..bae73a54b 100644
--- a/genl/ctrl.c
+++ b/genl/ctrl.c
@@ -267,7 +267,7 @@ static int ctrl_list(int cmd, int argc, char **argv)
 
 		if (argc != 2) {
 			fprintf(stderr, "Wrong number of params\n");
-			return -1;
+			goto ctrl_done;
 		}
 
 		if (matches(*argv, "name") == 0) {