From: Pick Date: Mon, 19 Jul 2021 21:59:30 +0000 (+0800) Subject: chore(reactivity): correct the description of the test case (#4135) X-Git-Tag: v3.2.0-beta.2~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35cc7b0d3117ff7dfe1c2cc06e84b1930fd28398;p=thirdparty%2Fvuejs%2Fcore.git chore(reactivity): correct the description of the test case (#4135) --- diff --git a/packages/reactivity/__tests__/effect.spec.ts b/packages/reactivity/__tests__/effect.spec.ts index 6a05038554..77d069fc61 100644 --- a/packages/reactivity/__tests__/effect.spec.ts +++ b/packages/reactivity/__tests__/effect.spec.ts @@ -850,7 +850,7 @@ describe('reactivity/effect', () => { expect(dummy).toBe(1) }) - it('should not be trigger when the value and the old value both are NaN', () => { + it('should not be triggered when the value and the old value both are NaN', () => { const obj = reactive({ foo: NaN }) @@ -884,13 +884,14 @@ describe('reactivity/effect', () => { expect(record).toBeUndefined() }) - it('should trigger once effect when set the equal proxy', () => { + it('should not be triggered when set with the same proxy', () => { const obj = reactive({ foo: 1 }) const observed: any = reactive({ obj }) const fnSpy = jest.fn(() => observed.obj) effect(fnSpy) + expect(fnSpy).toHaveBeenCalledTimes(1) observed.obj = obj expect(fnSpy).toHaveBeenCalledTimes(1) @@ -900,6 +901,7 @@ describe('reactivity/effect', () => { effect(fnSpy2) + expect(fnSpy2).toHaveBeenCalledTimes(1) observed2.obj2 = obj2 expect(fnSpy2).toHaveBeenCalledTimes(1) })